Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for CVSS vectors display #1312

Merged
merged 1 commit into from
Feb 13, 2024

Conversation

ziadhany
Copy link
Collaborator

@ziadhany ziadhany commented Sep 29, 2023

This is an example of how to display CVSS vectors

Screenshot 2023-09-29 at 03-09-53 VulnerableCode Vulnerability Details - VCID-115q-hx34-aaae

#1239

@ziadhany
Copy link
Collaborator Author

Should the table have horizontal or vertical heading?

Do we need to display all CVSS vector info or just the Base Score Metrics?

Should we display all options of attribute
for ex: Attack Vector: Network, Adjacent Network, Local , Physical
or we should just display the value?

@TG1999 TG1999 marked this pull request as draft October 10, 2023 03:35
@ziadhany
Copy link
Collaborator Author

image

@ziadhany ziadhany marked this pull request as ready for review November 7, 2023 16:26
@TG1999
Copy link
Contributor

TG1999 commented Nov 20, 2023

@ziadhany please resolve conflicts

Copy link
Contributor

@TG1999 TG1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ziadhany thanks++, review comments for your consideration

vulnerabilities/views.py Outdated Show resolved Hide resolved
vulnerabilities/severity_systems.py Show resolved Hide resolved
@TG1999 TG1999 marked this pull request as draft December 12, 2023 19:35
@TG1999 TG1999 marked this pull request as ready for review January 9, 2024 16:50
@TG1999
Copy link
Contributor

TG1999 commented Jan 9, 2024

@ziadhany please resolve merge conflicts : )

@ziadhany
Copy link
Collaborator Author

@ziadhany please resolve merge conflicts : )

@TG1999 Done!

@TG1999 TG1999 added this to the v34.0.0 milestone Jan 30, 2024
Copy link
Contributor

@TG1999 TG1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@TG1999
Copy link
Contributor

TG1999 commented Feb 5, 2024

@ziadhany please add changelog and merge this PR

Copy link
Contributor

@TG1999 TG1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix failing tests : )

Fix the cvss vector test
Resolve merge conflicts
Add exception for s.scoring_system when is not in SCORING_SYSTEMS
Add a get serverity values test
Resolve merge conflict
Change the style of cvss_printer display
Add a new filter to print cvss vectors
Change the table heading to Vertical
Add support for CVSS vectors display

Signed-off-by: ziadhany <[email protected]>
@ziadhany
Copy link
Collaborator Author

Please fix failing tests : )

Done

Copy link
Contributor

@TG1999 TG1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks++

@TG1999 TG1999 merged commit 61eeb72 into aboutcode-org:main Feb 13, 2024
6 of 7 checks passed
@ziadhany ziadhany deleted the cvss-v-display branch February 13, 2024 10:30
TG1999 pushed a commit to TG1999/vulnerablecode that referenced this pull request Jul 19, 2024
Fix the cvss vector test
Resolve merge conflicts
Add exception for s.scoring_system when is not in SCORING_SYSTEMS
Add a get serverity values test
Resolve merge conflict
Change the style of cvss_printer display
Add a new filter to print cvss vectors
Change the table heading to Vertical
Add support for CVSS vectors display

Signed-off-by: ziadhany <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants